Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Jul 28, 2025

The upstream commit that changed KVM_REG_ARM_SMCCC_ARCH_WORKAROUND_3 from NOT_REQUIRED to AVAIL on G4 has now also been backported to 5.10. Apply the same fix as commit 2551a1e ("chore(test/msr): update G4 fingerprint for SMCCC_ARCH_WORKAROUND_3") to the 5.10 G4 cpu template helper tool baseline.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

The upstream commit that changed KVM_REG_ARM_SMCCC_ARCH_WORKAROUND_3
from NOT_REQUIRED to AVAIL on G4 has now also been backported to 5.10.
Apply the same fix as commit  2551a1e ("chore(test/msr): update G4
fingerprint for SMCCC_ARCH_WORKAROUND_3") to the 5.10 G4 cpu template
helper tool baseline.

Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.03%. Comparing base (ba8ad7a) to head (95b519a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5331      +/-   ##
==========================================
+ Coverage   82.97%   83.03%   +0.06%     
==========================================
  Files         250      250              
  Lines       26837    26837              
==========================================
+ Hits        22268    22285      +17     
+ Misses       4569     4552      -17     
Flag Coverage Δ
5.10-c5n.metal 83.48% <ø> (?)
5.10-m5n.metal 83.48% <ø> (?)
5.10-m6a.metal 82.70% <ø> (ø)
5.10-m6g.metal 79.15% <ø> (ø)
5.10-m6i.metal 83.47% <ø> (?)
5.10-m7a.metal-48xl 82.69% <ø> (?)
5.10-m7g.metal 79.15% <ø> (ø)
5.10-m7i.metal-24xl 83.43% <ø> (?)
5.10-m7i.metal-48xl 83.44% <ø> (?)
5.10-m8g.metal-24xl 79.15% <ø> (?)
5.10-m8g.metal-48xl 79.14% <ø> (?)
6.1-c5n.metal 83.53% <ø> (?)
6.1-m5n.metal 83.53% <ø> (?)
6.1-m6a.metal 82.74% <ø> (?)
6.1-m6g.metal 79.15% <ø> (?)
6.1-m6i.metal 83.52% <ø> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.74% <ø> (?)
6.1-m7g.metal 79.15% <ø> (ø)
6.1-m7i.metal-24xl 83.54% <ø> (?)
6.1-m7i.metal-48xl 83.54% <ø> (?)
6.1-m8g.metal-24xl 79.14% <ø> (?)
6.1-m8g.metal-48xl 79.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat enabled auto-merge (rebase) July 28, 2025 13:28
@roypat roypat merged commit 0082734 into firecracker-microvm:main Jul 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants